count lines

GoogleChrome · Dec 7, 2019 · f9408f3 · f9408f3
1 parent 6d27caa
commit f9408f3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lighthouse-core/computed/bundle-analysis.js b/lighthouse-core/computed/bundle-analysis.js
@@ -84,7 +84,7 @@ function computeGeneratedFileSizesForCDT(sourceMapData) {
         // });
         continue;
       }
-      mappingLength = lastGeneratedColumn - generatedColumn + 0;
+      mappingLength = lastGeneratedColumn - generatedColumn;
     } else {
       // TODO Buffer.byteLength?
       mappingLength = line.length - generatedColumn;
@@ -93,10 +93,7 @@ function computeGeneratedFileSizesForCDT(sourceMapData) {
     mappedBytes += mappingLength;
   }
 
-  // TODO: remove?
-  // Don't count newlines as original version didn't count newlines
-  const totalBytes = content.length - lines.length + 1;
-
+  const totalBytes = content.length;
   return {
     files,
     unmappedBytes: totalBytes - mappedBytes,

diff --git a/lighthouse-core/test/fixtures/source-maps/foo.min.js b/lighthouse-core/test/fixtures/source-maps/foo.min.js