We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run LH 6.0.0.beta on any URL
lighthouse https://www.apple.com/
audits.metrics.details[0].cumulativeLayoutShift is 0
audits.metrics.details[0].cumulativeLayoutShift
But audits.cumulative-layout-shift.numericValue is 0.19574185519748266.
audits.cumulative-layout-shift.numericValue
0.19574185519748266.
I expect the value rounded to 3 decimals, like in the HTML Report: 0.196, because a good CLS value is 0.1 and it's a first float value in metrics.
0.196
0.1
metrics
The problem is related to this line of code: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/metrics.js#L41
The text was updated successfully, but these errors were encountered:
Great catch. I'll take care of this.
Sorry, something went wrong.
@patrickhulce could you take this? should be quick
sure thing 👍
patrickhulce
Successfully merging a pull request may close this issue.
Provide the steps to reproduce
Run LH 6.0.0.beta on any URL
What is the current behavior?
audits.metrics.details[0].cumulativeLayoutShift
is 0But
audits.cumulative-layout-shift.numericValue
is0.19574185519748266.
What is the expected behavior?
I expect the value rounded to 3 decimals, like in the HTML Report:
0.196
, because a good CLS value is0.1
and it's a first float value inmetrics
.The problem is related to this line of code: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/metrics.js#L41
Environment Information
The text was updated successfully, but these errors were encountered: