core(metrics): do not round CLS in output #10728

patrickhulce · 2020-05-07T22:50:08Z

Summary

Doesn't round CLS in the metrics audit.
Cleans up some of the extra timing data that was never being defined.
Adds tests in metrics audit for a trace with CLS and and a test for observed metrics which seemed to be lacking.

Related Issues/PRs
fixes #10486

patrickhulce · 2020-05-07T22:59:04Z

@connorjclark would you standardize this as core(metrics): do not round CLS in output instead?

I've noticed you've been on a PR title mission :)

connorjclark · 2020-05-07T22:59:51Z

yeah i don't like repeating the (...) bit.

core(metrics): do not round CLS in metrics output

7aeb4d2

patrickhulce requested a review from a team as a code owner May 7, 2020 22:50

patrickhulce requested review from paulirish and removed request for a team May 7, 2020 22:50

patrickhulce force-pushed the cls_round_0 branch from c05458d to 7aeb4d2 Compare May 7, 2020 22:50

googlebot added the cla: yes label May 7, 2020

vercel bot temporarily deployed to Preview May 7, 2020 22:50 Inactive

devtools-bot assigned paulirish May 7, 2020

devtools-bot added the waiting4reviewer label May 7, 2020

better names

5f0e2bf

vercel bot deployed to Preview May 7, 2020 22:51 View deployment

patrickhulce changed the title ~~core(metrics): do not round CLS in metrics output~~ core(metrics): do not round CLS in output May 8, 2020

paulirish approved these changes May 8, 2020

View reviewed changes

paulirish merged commit db2a0dc into master May 8, 2020

paulirish deleted the cls_round_0 branch May 8, 2020 20:02

Provide feedback