Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move remaining travis tests to github actions #11194

Closed
4 tasks done
brendankenny opened this issue Jul 30, 2020 · 2 comments
Closed
4 tasks done

Move remaining travis tests to github actions #11194

brendankenny opened this issue Jul 30, 2020 · 2 comments
Assignees
@brendankenny
Labels
needs-priority

Comments

@brendankenny
Copy link
Member

brendankenny commented Jul 30, 2020 •
edited
Loading

I thought there was an existing issue for this but maybe not.

anything else?
@brendankenny
Copy link
Member Author

open question: GitHub Actions is currently just Node 10. What should we do about Node 12/14 (and generally LTS vs latest in the future)?

@brendankenny brendankenny self-assigned this Jul 30, 2020
@brendankenny brendankenny mentioned this issue Jul 30, 2020
Merged
@patrickhulce
Copy link
Collaborator

What should we do about Node 12/14 (and generally LTS vs latest in the future)?

I'd say we just add the unit tests/basics for latest node so we're aware of any major issues, but other than that just keep everything on our lowest acceptable node version.

@connorjclark connorjclark mentioned this issue Dec 7, 2020
Closed
@connorjclark connorjclark mentioned this issue Dec 15, 2020
Merged
@connorjclark connorjclark mentioned this issue Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendankenny brendankenny

Labels
needs-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brendankenny @patrickhulce @exterkamp @devtools-bot