tests: run test-viewer in github actions #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
brendankenny
commented
Jul 30, 2020
| @@ -33,6 +33,8 @@ jobs: | |||
| run: xvfb-run --auto-servernum yarn test-bundle | |||
| - name: yarn test-docs | |||
| run: xvfb-run --auto-servernum yarn test-docs | |||
| - name: yarn test-viewer | |||
| run: xvfb-run --auto-servernum yarn test-viewer | |||
There was a problem hiding this comment.
needs yarn build-all (to get yarn build-viewer), xvfb, and is quite fast (11s locally, we'll see in CI), so here in basics seemed like the obvious choice.
There was a problem hiding this comment.
11s locally, we'll see in CI
13s
patrickhulce
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
gosh silly @brendankenny how dare this 2-line yaml change regress (impossibly?) our coverage! 😆
LGTM :)
|
That's real weird. Also I've never noticed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #11194
Kind of a ridiculously small PR, but the code coverage stuff is a lot more involved.