-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make NO_LCP error message specific to LCP #14554
Comments
This is intentional and it's not connected to |
Is the error message maybe to alarming for this case? If the outcome (NO_LCP) is expected in this case then we can assume that nothing went wrong with the recording and that running Lighthouse again won't solve anything. |
Yeah, a lot of the NO_LCP cases aren't actually fixed by running Lighthouse again. This message is used for several errors relating to the trace, but we could use something more specific to LCP. I would support rephrasing this message to something like: "The page did not paint anything that qualifies as LCP. Ensure the page has a valid LCP element and then try again. (NO_LCP)" |
Thank you @adamraine for this speedy update! The new message is much clearer imo. |
FAQ
URL
https://jsbin.com/pajibab/edit?html,output
What happened?
When analyzing page load with mode: navigation, device: mobile and categories: performance there is an error on the LCP metric.
We receive the following message:
Something went wrong with recording the trace over your page load. Please run Lighthouse again. (NO_LCP)
This error error does not occur when analyzing page load desktop on desktop.
What did you expect?
Would have expected a similar result as when running the test on desktop. Where the error does not occur.
What have you tried?
Made a minimal html page with only the image with css style object-fit: cover defined to make sure nothing else might be causing the issue.
How were you running Lighthouse?
Chrome DevTools
Lighthouse Version
9.6.6
Chrome Version
107.0.5304.110
Node Version
No response
OS
Mac
Relevant log output
No response
The text was updated successfully, but these errors were encountered: