Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: use LCP specific message for NO_LCP #14556

Merged
merged 4 commits into from
Nov 22, 2022
Merged

core: use LCP specific message for NO_LCP #14556

merged 4 commits into from
Nov 22, 2022

Conversation

adamraine
Copy link
Member

Closes #14554

@adamraine adamraine requested a review from a team as a code owner November 22, 2022 15:57
@adamraine adamraine requested review from connorjclark and removed request for a team November 22, 2022 15:57
brendankenny
brendankenny reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, much better

core/lib/lh-error.js Outdated Show resolved Hide resolved
adamraine and others added 2 commits November 22, 2022 08:11
@adamraine @brendankenny
Update core/lib/lh-error.js
92b9446 
Co-authored-by: Brendan Kenny <bckenny@gmail.com>
@adamraine
ope
1eacd78
@devtools-bot devtools-bot merged commit e3f2337 into main Nov 22, 2022
@devtools-bot devtools-bot deleted the lcp-specific-error branch November 22, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@connorjclark connorjclark

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make NO_LCP error message specific to LCP
4 participants
@adamraine @brendankenny @connorjclark @devtools-bot