Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y gatherer hangs on https://almanac.httparchive.org/en/2021/ecommerce #15824

Closed
connorjclark opened this issue Feb 21, 2024 · 8 comments
Closed

Comments

@connorjclark
Copy link
Collaborator

This results in a PROTOCOL_TIMEOUT:

node cli https://almanac.httparchive.org/en/2021/ecommerce --only-categories=accessibility

Did not happen in 10.0

I bisected to: #15216

cc @tunetheweb

@connorjclark
Copy link
Collaborator Author

target-size is taking forever.

@tunetheweb
Copy link
Member

FYI I have "identical-links-same-purpose": "off", in my config.

Will try it with target-size turned off too...

@connorjclark
Copy link
Collaborator Author

It will still run in axe, since we don't connect our audit ids to the axe config like that (but we should ..)

@adamraine
Copy link
Member

I think we should upstream this bug to axe if we can. Even though the audit is hidden, we eventually want to use it and I think disabling it completely will lose value in HTTPA runs (ironic that this happens on https://almanac.httparchive.org/en/2021/ecommerce tho haha).

@tunetheweb
Copy link
Member

FYI, I also saw problems with https://almanac.httparchive.org/en/2021/webassembly

Both have a lot of web mentions (which we render at the bottom of the page). Turning this functionality off (https://almanac.httparchive.org/en/2021/webassembly?nowebmentions) allowed the page to pass Lighthouse runs.

So either the DOM's got too large with those, or axe doesn't handle a page with a lot of similar things. A lot of them do have the same "View Source" link despite pointing to different sources which might fail the new identical-links-same-purpose (docs) audit?

image

@connorjclark
Copy link
Collaborator Author

connorjclark commented Feb 22, 2024

target-size is taking forever.

should clarify, of that commit i bisected to this was the only thing that was a problem. Disabling target-size axe check was the only thing necessary to allow the run to finish.

@adamraine
Copy link
Member

dequelabs/axe-core#4360

We can disable the target-size rule temporarily. If axe fixes this issue or we decide to elevate target-size to the report UI then we should re enable it.

@adamraine
Copy link
Member

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants