Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtimeError #15825

Open
connorjclark opened this issue Feb 21, 2024 · 1 comment
Open

Improve runtimeError #15825

connorjclark opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Feb 21, 2024

#15824 produces these errors in the LHR:

"runtimeError": {
  "code": "PROTOC OL_TIMEOUT",
  "message": "Waiting for DevTools protocol response has exceeded the allotted time. (Method: Runtime.evaluate)"
},
...
"accesskeys": {
  "id": "accesskeys",
  "title": "`[accesskey]` values are unique",
  "description": "Access keys let users quickly focus a part of the page. For proper navigation, each access key must be unique. [Learn more about access keys](https://dequeuniversity.com/rules/axe/4.8/accesskeys).",
  "score": null,
  "scoreDisplayMode": "error",
  "errorMessage": "Required Accessibility gatherer encountered an error: PROTO COL_TIMEOUT",
  "errorStack": "LighthouseError: PROTO COL_TIMEOUT\n    at file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/session.js:102:47\n    at new Promise (<anonymous>)\n    at ProtocolSession.sendCommand (file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/session.js:100:28)\n    at ExecutionContext._evaluateInContext (file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/driver/execution-context.js:128:42)\n    at ExecutionContext.evaluateAsync (file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/driver/execution-context.js:173:25)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/runner-helpers.js:106:24\n    at async collectPhaseArtifacts (file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/runner-helpers.js:123:5)\n    at async _computeNavigationResult (file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/navigation-runner.js:186:5)\n    at async file:///usr/local/google/home/cjamcl/code/lighthouse/core/gather/navigation-runner.js:310:25"
},
  1. runtimeError should have a stack trace
  2. I want to know which gatherer or whatever failed from runtimeError
  3. Can we possibly get async stack traces? the stack in the audit error is missing the line that actually issued the Runtime.evaluate
@connorjclark
Copy link
Collaborator Author

@paulirish can you kill this bot

@connorjclark connorjclark reopened this Feb 21, 2024
@paulirish paulirish changed the title Improve runtimeError Improve runtim eError Feb 21, 2024
@paulirish paulirish changed the title Improve runtim eError Improve runtimeError Feb 21, 2024
@GoogleChrome GoogleChrome deleted a comment from devtools-bot Feb 22, 2024
@GoogleChrome GoogleChrome deleted a comment from devtools-bot Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants