Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme for Instructions for running lighthouse cli for site with authentication. #2404

Closed
mikerhyssmith opened this issue May 31, 2017 · 2 comments · Fixed by #2409
Closed

Comments

@mikerhyssmith
Copy link
Contributor

The current instructions in the documentation for running lighthouse against a site where you need to login first are:

  • Run chrome-debug
  • navigate to and log in to your site
  • in a separate terminal tab lighthouse http://mysite.com

However, from what I can see for this to work when you run the lighthouse command you would need to add --port and the port number the chrome-debug instance is running on otherwise it opens a new instance of Chrome.

Happy to open a PR if this is the best way but it might be there's a better way of doing this !

@ebidel
Copy link
Contributor

ebidel commented May 31, 2017

Correct. The chrome launcher was changed to select a random port rather than defaulting to 9222.

PR would be great which adds the --port!

cc @samccone @paulirish another case where a rando port makes things harder.

@brendankenny
Copy link
Member

yeah, #2259 would fix a lot of those cases but not this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants