-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated readme to add port number when testing a site with authentication #2409
Conversation
docs/readme.md
Outdated
@@ -51,7 +51,7 @@ instance with an open debugging port. | |||
|
|||
- Run `chrome-debug` | |||
- navigate to and log in to your site | |||
- in a separate terminal tab `lighthouse http://mysite.com` | |||
- in a separate terminal tab `lighthouse http://mysite.com --port port-number` with the debugging port number your Chrome instance is running on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a note that it's 9222 by default or use it as the example port?
wait, wasn't the whole point that |
I thought Lighthouse was looking to launch one on a random port but the instructions told you to open one already at 9222? |
Oh no it tells you to use chrome-debug nevermind ignore me :) why don't we default chrome-debug to 9222 then? |
Is it worth adding a note in the readme that chrome-debug will log the port its running on to then use in the lighthouse command ? |
aight carry on then @mikerhyssmith that sounds good to me :) |
yup. let's do that :) |
… number provided by chrome-debug
fixes #2404