Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme to add port number when testing a site with authentication #2409

Merged
merged 3 commits into from
May 31, 2017
Merged

Updated readme to add port number when testing a site with authentication #2409

merged 3 commits into from
May 31, 2017

Conversation

mikerhyssmith
Copy link
Contributor

@mikerhyssmith mikerhyssmith commented May 31, 2017

fixes #2404

docs/readme.md Outdated
@@ -51,7 +51,7 @@ instance with an open debugging port.

- Run `chrome-debug`
- navigate to and log in to your site
- in a separate terminal tab `lighthouse http://mysite.com`
- in a separate terminal tab `lighthouse http://mysite.com --port port-number` with the debugging port number your Chrome instance is running on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a note that it's 9222 by default or use it as the example port?

@brendankenny
Copy link
Member

wait, wasn't the whole point that chrome-debug now uses a random port and doesn't have a default?

@patrickhulce
Copy link
Collaborator

now uses a random port and doesn't have a default?

I thought Lighthouse was looking to launch one on a random port but the instructions told you to open one already at 9222?

@patrickhulce
Copy link
Collaborator

Oh no it tells you to use chrome-debug nevermind ignore me :) why don't we default chrome-debug to 9222 then?

@paulirish
Copy link
Member

why don't we default chrome-debug to 9222 then?

I made that call. Mostly because it's possible of a port conflict and I wanted to make sure that chrome-debug command always works even if you have a second one already launched.

The output now says what port it's on, so it seems kinda reasonable to ask the user to use that port.
image

wdyt

@mikerhyssmith
Copy link
Contributor Author

Is it worth adding a note in the readme that chrome-debug will log the port its running on to then use in the lighthouse command ?

@patrickhulce
Copy link
Collaborator

aight carry on then @mikerhyssmith that sounds good to me :)

@paulirish
Copy link
Member

Is it worth adding a note in the readme that chrome-debug will log the port its running on to then use in the lighthouse command ?

yup. let's do that :)

@paulirish paulirish merged commit 400457b into GoogleChrome:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Readme for Instructions for running lighthouse cli for site with authentication.
4 participants