-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chrome host as parameter #2727
Comments
Not doing anything wrong, I believe you're just the first request we've had for this :) Makes sense to have as an option though it could be plumbed through as |
Decided to make hostname second parameter to avoid breaking existing implementations
I believe the pull request I just created has fulfilled your request. You might want to check it out and make sure that everything is as you want it. Additionally, you may want to note that the |
Convert the parameter conf to object to make it more extensible
Sorry for such a late answer. |
I'm looking to use lighthouse (which is really well done) programmatically integrating it inside another node app and I'm having some issues as the node app and headless-chrome are running inside two different containers.
This assumes chrome is always located on
localhost
and allows you to change only the port.Would it make sense to call the constructor with a config object like
{ host: DEFAULT_HOST, port: DEFAULT_PORT }
or I'm just doing something weird and there's another way to specify the host?The text was updated successfully, but these errors were encountered: