Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rel=noopener audit should ignore href=javascript:.* #3079

Closed
patrickhulce opened this issue Aug 22, 2017 · 5 comments · Fixed by #3574
Closed

rel=noopener audit should ignore href=javascript:.* #3079

patrickhulce opened this issue Aug 22, 2017 · 5 comments · Fixed by #3574
Labels
bug good first issue new_audit P1

Comments

@patrickhulce
Copy link
Collaborator

discovered in #3074

auditing google.com flags <a href="javascript:void(0)" target="_blank"> as a failure
@patrickhulce patrickhulce mentioned this issue Aug 22, 2017
Closed
@AdarshKonchady
Copy link

@patrickhulce Is this still an issue? Can I take this?

@paulirish
Copy link
Member

@akonchady go for it. :)

@patrickhulce
Copy link
Collaborator Author

hey @akonchady were you still planning on taking this up? :)

@karanjthakkar
Copy link
Contributor

Since I was involved in the initial PR that got this audit in #912, I was wondering if I could give this a shot if @akonchady hasn't already started working on it?

karanjthakkar added a commit to karanjthakkar/lighthouse that referenced this issue Oct 16, 2017
@karanjthakkar
fix: Ignore href=javascript:.* for rel=noopener audit
e425d30 
Fixes GoogleChrome#3079
@karanjthakkar karanjthakkar mentioned this issue Oct 16, 2017
Merged
@AdarshKonchady
Copy link

Thanks @karanjthakkar for the PR. I wasn't able to take this up.

karanjthakkar added a commit to karanjthakkar/lighthouse that referenced this issue Oct 16, 2017
@karanjthakkar
ignore href=javascript:.* for rel=noopener audit
d9b2a37 
Fixes GoogleChrome#3079
karanjthakkar added a commit to karanjthakkar/lighthouse that referenced this issue Oct 16, 2017
@karanjthakkar
core(audit): ignore href=javascript:.* for rel=noopener audit
d05f19c 
ISSUES CLOSED: GoogleChrome#3079
karanjthakkar added a commit to karanjthakkar/lighthouse that referenced this issue Oct 16, 2017
@karanjthakkar
core(audit): ignore href=javascript:.* for rel=noopener audit
ca1228c 
ISSUES CLOSED: GoogleChrome#3079
karanjthakkar added a commit to karanjthakkar/lighthouse that referenced this issue Oct 16, 2017
@karanjthakkar
core(audit): ignore href=javascript:.* for rel=noopener audit
b661b02 
ISSUES CLOSED: GoogleChrome#3079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue new_audit P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core(audit): Ignore href=javascript:.* for rel=noopener audit karanjthakkar/lighthouse
4 participants
@paulirish @AdarshKonchady @karanjthakkar @patrickhulce