Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audits Meta: Feature parity with PSI, MFT, DevTools #909

Closed
12 of 16 tasks
ebidel opened this issue Nov 5, 2016 · 9 comments
Closed
12 of 16 tasks

Audits Meta: Feature parity with PSI, MFT, DevTools #909

ebidel opened this issue Nov 5, 2016 · 9 comments
Labels
needs-priority new_audit
Milestone
Q1 2017

Comments

@ebidel
Copy link
Contributor

ebidel commented Nov 5, 2016 •
edited by paulirish
Loading

updated by @paulirish jan 2018

For parity with Pagespeed Insights

For parity with Mobile-Friendly Test:

For parity with legacy DevTools Audit panel:

  • Unused CSS rules
    • dependent on the new css coverage backend that landed in early nov.
  • Styles & script order
@paulirish
Copy link
Member

some basic info added, more to come.

@patrickhulce
Copy link
Collaborator

after talking with paul, the styles & script order don't seem to really apply anymore. we came up with #943 instead. any thoughts or arguments for keeping those particular audit rules around @ebidel?

@ebidel
Copy link
Contributor Author

ebidel commented Nov 15, 2016

Not from I. This seems like a good time to modernize them :)

@ebidel ebidel changed the title Meta: Audits 2.0 panel parity with Audits 1.0 Meta: Audits 2.0 panel parity with PSI / Audits 1.0 Jan 3, 2017
patrickhulce added a commit that referenced this issue Jan 6, 2017
@patrickhulce
feat: add CSS usage tracking
1b02e46 
Adds basic CSS rule usage tracking gatherer and audit. Moves toward parity with Audits 1.0 as per #909.
@patrickhulce patrickhulce mentioned this issue Jan 6, 2017
Merged
@ebidel
Copy link
Contributor Author

ebidel commented Jan 11, 2017

Updated the list with the css usage tracking. That's imminent.

brendankenny pushed a commit that referenced this issue Jan 11, 2017
@patrickhulce @brendankenny
add CSS usage tracking gatherer and audit (#1421)
bbaff25 
Adds basic CSS rule usage tracking gatherer and audit. Moves toward parity with Audits 1.0 as per #909.
@igrigorik
Copy link

Re, parity.. Looking at the list, I think there are two audits missing:

@ebidel
Copy link
Contributor Author

ebidel commented Jan 11, 2017

Thanks @igrigorik. Added those to the top.

patrickhulce added a commit that referenced this issue Jan 12, 2017
@patrickhulce
feat(DBW): add audit for detecting unoptimized images
bd7ceb5 
Addresses one of several concerns around image bloat and another step towards PSI parity (#909).

Gathers all sameorigin or data URI images off of the network and runs them through canvas to determine a stripped down JPEG and WebP size.

Audit will fail if one of the conditions are met:
* There is at least one JPEG or bitmap image that was larger than canvas encoded JPEG.
* There is at least one image that would have saved more than 50KB by using WebP.
* The savings of moving all images to WebP is greater than 100KB.
@patrickhulce patrickhulce mentioned this issue Jan 12, 2017
Merged
andrewrota pushed a commit to andrewrota/lighthouse that referenced this issue Jan 13, 2017
@patrickhulce @andrewrota
add CSS usage tracking gatherer and audit (GoogleChrome#1421)
c0a06e3 
Adds basic CSS rule usage tracking gatherer and audit. Moves toward parity with Audits 1.0 as per GoogleChrome#909.
@brendankenny
Copy link
Member

#1452 addresses unoptimized images, though it would be nice to have a place to track building on that to try to quantify the load time added by not using better compression.

@ebidel ebidel modified the milestone: Q1 2017 Jan 17, 2017
@paulirish paulirish changed the title Meta: Audits 2.0 panel parity with PSI / Audits 1.0 Audits Meta: Feature parity with PSI, MFT, Audits Feb 3, 2017
@paulirish paulirish changed the title Audits Meta: Feature parity with PSI, MFT, Audits Audits Meta: Feature parity with PSI, MFT, DevTools Feb 3, 2017
@paulirish paulirish mentioned this issue Feb 4, 2017
Merged
@patrickhulce patrickhulce mentioned this issue Mar 3, 2017
Merged
This was referenced Oct 2, 2017
Closed
Closed
@paulirish
Copy link
Member

As of 2.8.0 nearly all the parity audits are complete! Boom.

@paulirish
Copy link
Member

We good here. Follow the linked issues above for individual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-priority new_audit
Projects
None yet
Milestone
Q1 2017
Development

No branches or pull requests
5 participants
@igrigorik @paulirish @ebidel @brendankenny @patrickhulce