Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

releasing on Linux is ~broken #9682

Closed
exterkamp opened this issue Sep 16, 2019 · 1 comment
Closed

releasing on Linux is ~broken #9682

exterkamp opened this issue Sep 16, 2019 · 1 comment

Comments

@exterkamp
Copy link
Member

Releasing on Linux isn't perfect b/c some sed commands don't work...

#roll-to-devtools.sh
sed -i '' -e "s/Version:.*/Version: $VERSION/g" "$tests_dir"/*-expected.txt
#prepare-commit.sh
sed -i '' "s/$NEEDLE/$REPLACEMENT/g" package.json clients/extension/manifest.json

Removing the '' works, but this might break mac.

@connorjclark
Copy link
Collaborator

dupe #9857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants