Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☔ release script improvements #9857

Closed
5 of 14 tasks
connorjclark opened this issue Oct 17, 2019 · 4 comments
Closed
5 of 14 tasks

☔ release script improvements #9857

connorjclark opened this issue Oct 17, 2019 · 4 comments
Labels

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Oct 17, 2019

  • smokehouse tmp directory breaks test.sh (test(smokehouse): fix tmp dir usage #9855)
  • devtools: add git commit with the expected commit message filled out
  • devtools: kick off CQ from CLI
  • lr: internal roll script does not use lighthouse-pristine. this is fine when used for development, but when using to roll a release the script should use pristine
  • lr: auto update lhVersion variable
  • sed doesn't work in linux. Instead of fixing this, I think the scripts should be rewritten in Node
  • new contributors should show github names. there may be no API for this, at the least we should log the links to the PRs of new contributors so the usernames can be quickly found
  • changelog category order should be specified based on the adhoc ordering we've done (by importance) (misc: order changelog categories. add stable chrome note placeholder #9859)
  • changelog generator should include "We expect this release to ship in the DevTools of Chrome XX." with a link to the chrome release dashboard (misc: order changelog categories. add stable chrome note placeholder #9859)
  • the bump branch should be named "v$VERSION", that will cause github to set the default PR name to "v$VERSION", making the commit use the same, and passing the "v$VERSION" check that the release script does
  • tag isn't pushed
  • v6.1.0 #11025 (comment)
  • date is off by one https://github.com/GoogleChrome/lighthouse/pull/11730/files#r533013519
  • consider running test in Actions using npm pack
@exterkamp exterkamp changed the title ☔ release script improvements ☔ release script improvements Oct 17, 2019
@connorjclark
Copy link
Collaborator Author

sed doesn't work in linux. Instead of fixing this, I think the scripts should be rewritten in Node

@patrickhulce WDYT of this?

@patrickhulce
Copy link
Collaborator

patrickhulce commented Nov 5, 2019

sed doesn't work in linux.

I'm not sure I believe this statement :) but if you feel it's much easier to accomplish all of this in node then sure let's go for it! the goal of these scripts are to reduce the burden on the releaser as much as possible so whatever accomplishes that SGTM

@connorjclark
Copy link
Collaborator Author

I elided the important info. We use a sed extension that is only standard on Mac.

@connorjclark
Copy link
Collaborator Author

I think we're happy with the release scripts today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants