core(unused-javascript): augment with source maps

.eslintignore

@@ -4,6 +4,9 @@
 
 **/node_modules/**
 **/third_party/**
+**/generated/**
+**/source-maps/**
+lighthouse-cli/test/fixtures/byte-efficiency/bundle.js
 
 /dist/**
 

build/build-cdt-lib.js

@@ -0,0 +1,65 @@
+/**
+ * @license Copyright 2019 Google Inc. All Rights Reserved.
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+ */
+'use strict';
+
+const fs = require('fs');
+const {execFileSync} = require('child_process');
+const glob = require('glob');
+
+const files = [
+  'node_modules/chrome-devtools-frontend/front_end/sdk/SourceMap.js',
+];
+const outDir = 'lighthouse-core/lib/cdt/generated';
+
+execFileSync('node_modules/.bin/tsc', [
+  '--allowJs',
+  '--outDir',
+  outDir,
+  ...files,
+]);
+
+// eslint-disable-next-line no-console
+console.log('making modifications ...');
+
+for (const file of glob.sync(`${outDir}/**/*.js`)) {
+  const code = fs.readFileSync(file, 'utf-8');
+
+  let lines = code.match(/^.*(\r?\n|$)/mg) || [];
+  const cutoffIndex = lines.findIndex(line => line.includes('Legacy exported object'));
+  lines = lines.splice(0, cutoffIndex);
+
+  let deletionMode = false;
+
+  const modifiedLines = lines.map((line, i) => {
+    // Don't modify jsdoc comments.
+    if (/^\s*[/*]/.test(line)) {
+      return line;
+    }
+
+    let newLine = line;
+    if (file.endsWith('SourceMap.js')) {
+      if (line.includes('TextSourceMap.load =')) deletionMode = true;
+      if (line.includes('prototype.sourceContentProvider =')) deletionMode = true;
+      if (line.includes(`url += Common.UIString('? [sm]');`)) newLine = '';
+      newLine = line.replace(`Common.ParsedURL.completeURL(this._baseURL, href)`, `''`);
+    }
+    newLine = newLine.replace('exports["default"]', 'exports.default');
+    if (deletionMode) {
+      newLine = '';
+      if (line.startsWith('    };')) deletionMode = false;
+    }
+
+    if (newLine !== line) {
+      // eslint-disable-next-line no-console
+      console.log(`${file}:${i}: ${line.trim()}`);
+    }
+    return newLine;
+  });
+  modifiedLines.unshift(`const Common = require('../Common.js')\n`);
+  modifiedLines.unshift('// generated by build-cdt-lib.js\n');
+  modifiedLines.unshift('// @ts-nocheck\n');
+  fs.writeFileSync(file, modifiedLines.join(''));
+}

lighthouse-cli/test/fixtures/byte-efficiency/bundle.js

@@ -0,0 +1,157 @@
+/******/ (function(modules) { // webpackBootstrap
+/******/ 	// The module cache
+/******/ 	var installedModules = {};
+/******/
+/******/ 	// The require function
+/******/ 	function __webpack_require__(moduleId) {
+/******/
+/******/ 		// Check if module is in cache
+/******/ 		if(installedModules[moduleId]) {
+/******/ 			return installedModules[moduleId].exports;
+/******/ 		}
+/******/ 		// Create a new module (and put it into the cache)
+/******/ 		var module = installedModules[moduleId] = {
+/******/ 			i: moduleId,
+/******/ 			l: false,
+/******/ 			exports: {}
+/******/ 		};
+/******/
+/******/ 		// Execute the module function
+/******/ 		modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
+/******/
+/******/ 		// Flag the module as loaded
+/******/ 		module.l = true;
+/******/
+/******/ 		// Return the exports of the module
+/******/ 		return module.exports;
+/******/ 	}
+/******/
+/******/
+/******/ 	// expose the modules object (__webpack_modules__)
+/******/ 	__webpack_require__.m = modules;
+/******/
+/******/ 	// expose the module cache
+/******/ 	__webpack_require__.c = installedModules;
+/******/
+/******/ 	// define getter function for harmony exports
+/******/ 	__webpack_require__.d = function(exports, name, getter) {
+/******/ 		if(!__webpack_require__.o(exports, name)) {
+/******/ 			Object.defineProperty(exports, name, { enumerable: true, get: getter });
+/******/ 		}
+/******/ 	};
+/******/
+/******/ 	// define __esModule on exports
+/******/ 	__webpack_require__.r = function(exports) {
+/******/ 		if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
+/******/ 			Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
+/******/ 		}
+/******/ 		Object.defineProperty(exports, '__esModule', { value: true });
+/******/ 	};
+/******/
+/******/ 	// create a fake namespace object
+/******/ 	// mode & 1: value is a module id, require it
+/******/ 	// mode & 2: merge all properties of value into the ns
+/******/ 	// mode & 4: return value when already ns object
+/******/ 	// mode & 8|1: behave like require
+/******/ 	__webpack_require__.t = function(value, mode) {
+/******/ 		if(mode & 1) value = __webpack_require__(value);
+/******/ 		if(mode & 8) return value;
+/******/ 		if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
+/******/ 		var ns = Object.create(null);
+/******/ 		__webpack_require__.r(ns);
+/******/ 		Object.defineProperty(ns, 'default', { enumerable: true, value: value });
+/******/ 		if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
+/******/ 		return ns;
+/******/ 	};
+/******/
+/******/ 	// getDefaultExport function for compatibility with non-harmony modules
+/******/ 	__webpack_require__.n = function(module) {
+/******/ 		var getter = module && module.__esModule ?
+/******/ 			function getDefault() { return module['default']; } :
+/******/ 			function getModuleExports() { return module; };
+/******/ 		__webpack_require__.d(getter, 'a', getter);
+/******/ 		return getter;
+/******/ 	};
+/******/
+/******/ 	// Object.prototype.hasOwnProperty.call
+/******/ 	__webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
+/******/
+/******/ 	// __webpack_public_path__
+/******/ 	__webpack_require__.p = "";
+/******/
+/******/
+/******/ 	// Load entry module and return exports
+/******/ 	return __webpack_require__(__webpack_require__.s = 0);
+/******/ })
+/************************************************************************/
+/******/ ([
+/* 0 */
+/***/ (function(module, exports, __webpack_require__) {
+
+  const a = __webpack_require__(1);
+  const b = __webpack_require__(2);
+  const c = __webpack_require__(3);
+
+  if (true) {
+    a();
+    b.half();
+  } else {}
+
+
+  /***/ }),
+  /* 1 */
+  /***/ (function(module, exports) {
+
+  module.exports = function() {
+    const kb2 = '................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................';
+    let i;
+    for (i = 0; i < 100; i++) {
+        i = i;
+    }
+    return i;
+  }
+
+
+  /***/ }),
+  /* 2 */
+  /***/ (function(module, exports) {
+
+  function half() {
+    const kb2 = '................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................';
+    let i;
+    for (i = 0; i < 100; i++) {
+      i = i;
+    }
+    return i;
+  }
+
+  function otherHalf() {
+    const kb2 = '................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................';
+    let i;
+    for (i = 0; i < 100; i++) {
+      i = i;
+    }
+    return i;
+  }
+
+
+  module.exports = {half, otherHalf};
+
+
+  /***/ }),
+  /* 3 */
+  /***/ (function(module, exports) {
+
+  module.exports = function() {
+      const kb2 = '................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................';
+      let i;
+      for (i = 0; i < 100; i++) {
+          i = i;
+      }
+      return i;
+    }
+
+
+  /***/ })
+  /******/ ]);
+  //# sourceMappingURL=bundle.js.map

lighthouse-cli/test/fixtures/byte-efficiency/tester.html

@@ -54,6 +54,7 @@
   }
 </style>
 <script src="script.js"></script>
+<script src="bundle.js"></script>
 </head>
 
 <body>

lighthouse-cli/test/smokehouse/test-definitions/byte-efficiency/expectations.js

@@ -44,6 +44,12 @@ const expectations = [
                 wastedBytes: '6559 +/- 100',
                 wastedPercent: 100,
               },
+              {
+                url: 'http://localhost:10200/byte-efficiency/bundle.js',
+                totalBytes: '13000 +/- 1000',
+                wastedBytes: '2500 +/- 100',
+                wastedPercent: '19 +/- 5',
+              },
             ],
           },
         },
@@ -60,9 +66,38 @@ const expectations = [
           details: {
             overallSavingsBytes: '>=25000',
             overallSavingsMs: '>300',
-            items: {
-              length: 2,
-            },
+            items: [
+              {
+                url: 'http://localhost:10200/byte-efficiency/script.js',
+                totalBytes: '53000 +/- 1000',
+                wastedBytes: '22000 +/- 1000',
+              },
+              {
+                url: 'http://localhost:10200/byte-efficiency/tester.html',
+                totalBytes: '15000 +/- 1000',
+                wastedBytes: '6500 +/- 1000',
+              },
+              {
+                url: 'http://localhost:10200/byte-efficiency/bundle.js',
+                totalBytes: 13064,
+                wastedBytes: 5870,
+                sources: [
+                  'webpack:///./c.js',
+                  'webpack:///./b.js',
+                  'webpack:///webpack/bootstrap',
+                ],
+                sourceBytes: [
+                  2223,
+                  4432,
+                  2740,
+                ],
+                sourceWastedBytes: [
+                  2204,
+                  2198,
+                  1234,
+                ],
+              },
+            ],
           },
         },
         'offscreen-images': {
@@ -94,7 +129,7 @@ const expectations = [
             overallSavingsMs: '>700',
             overallSavingsBytes: '>50000',
             items: {
-              length: 2,
+              length: 3,
             },
           },
         },