Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: experimental config #10333

Merged
merged 1 commit into from
Feb 13, 2020
Merged

core: experimental config #10333

merged 1 commit into from
Feb 13, 2020

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Feb 13, 2020

The config made in #10311 is too restrained. A config for experiments is really what I'd want. #10303 legacy-javascript would be one such audit, along with all the source map stuff meant for the previous config.

Something like this is useful IMO because adding a line in the default-config to test a nonstandard audit (and then remembering to delete that line) is annoying. for example: when we had unused-javascript not in the default config.

@connorjclark connorjclark requested a review from a team as a code owner February 13, 2020 08:19
@patrickhulce
Copy link
Collaborator

It's almost as if full-config were a useful idea we should've kept around 😱

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit b1dc2cf into master Feb 13, 2020
@patrickhulce patrickhulce deleted the experimental-config branch February 13, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants