core(long-tasks): add startTime property #10942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Jun 12, 2020
| expect(result.details.items).toHaveLength(0); | ||
| expect(result.score).toBe(1); |
There was a problem hiding this comment.
FYI @Beytoven I moved these down so that when there's a failure you get the debug information about what's inside details.items instead of expected: 1, received: 0 :)
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Jul 6, 2020
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
startTimeproperty for both simulated and observed modes in the long tasks diagnostic. Paves the way for #10806Example from The Verge on a simulated run
Related Issues/PRs
unblocks @Beytoven 's ability to execute on #10806