report: don't dim disclaimer anchor links #10981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the viewer it is currently hard to tell that 'See calculator' is a link, as it matches the same grey as the paragraph. PR removes this styling to mach other links in the audit.
paulirish
changed the title
|
I think the underline issue is lighthouse-metrics.com's bug: https://twitter.com/paul_irish/status/1275596637050552320 but that said.... I can't really give a decent justification for why these links don't get a link color, but the rest do. so yeah. let's do this. 👍 |
paulirish
approved these changes
Jun 24, 2020
|
Thanks @Nooshu for tracking down the code and making a great PR. appreciate it. :) |
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfix: In the viewer it is currently hard to tell that 'See calculator' is a link, as it matches the same grey as the paragraph. PR removes this styling to mach other links in the audit results (light blue)
Before
After
