Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fraggle Rock Phase 1 Prototype #11622

Closed
wants to merge 1 commit into from
Closed

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Nov 2, 2020

Summary

This PR will not be merged, please do not comment on naming, any code style/readability issues, or the FR API surface yet. Macro-level approach commentary welcome :)

This PR is intended to give a better sense of how the tiny Fraggle Rock PRs for Phase 1 are meant to come together. It's a cleanish version of just the phase 1 bits from a local FR prototype without tests. It can generate a report of a URL for all audits that only rely on evaluateAsync (all other audits will error). If anything jumps out to you about the way in which FR integrates with the runner, or the fact that we have a new driver that gets passed to our gatherers, that's what is worth discussion at this stage.

Goals of Phase 1 (see #11313 for more detail):

  • Enable early end-to-end testing of fraggle rock.
  • Minimal disruption to mainline core development.
  • Establish migration path for existing gatherers upon which future phases will build.

I'll be breaking the gist of this into PR into several smaller chunks for landing.

Related Issues/PRs
ref #11313 #11623 #11633

@patrickhulce
Copy link
Collaborator Author

We've mostly caught up here at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant