-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(console): replace ConsoleMessages and RuntimeExceptions artifacts #11663
Conversation
I'll work on making the changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
...mium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt
Outdated
Show resolved
Hide resolved
…hthouse/lighthouse-successful-run-expected.txt
@@ -733,4 +730,3 @@ viewport-ad-density | |||
visual-order-follows-dom | |||
without-javascript | |||
works-offline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works-offline | |
works-offline | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I've found a bug in GitHub suggestions 😆
…hthouse/lighthouse-successful-run-expected.txt
Summary
Creates a new
Console
gatherer that collects all messages from the console in a single artifact. It subsumes theConsoleMessages
andRuntimeExceptions
gatherers and adds new functionality to collectconsole
API calls.Open questions:
console.error
calls in the console errors audit? My guess is no but want to confirm since it's now trivial to changeRelated Issues/PRs
Fixes #11597