core(without-javascript): remove audit

lighthouse-cli/test/cli/__snapshots__/index-test.js.snap

@@ -18,9 +18,6 @@ Object {
     Object {
       "path": "viewport",
     },
-    Object {
-      "path": "without-javascript",
-    },
     Object {
       "path": "metrics/first-contentful-paint",
     },
@@ -1149,11 +1146,6 @@ Object {
           "id": "viewport",
           "weight": 2,
         },
-        Object {
-          "group": "pwa-optimized",
-          "id": "without-javascript",
-          "weight": 1,
-        },
         Object {
           "group": "pwa-optimized",
           "id": "apple-touch-icon",
@@ -1488,9 +1480,6 @@ Object {
         Object {
           "path": "http-redirect",
         },
-        Object {
-          "path": "html-without-javascript",
-        },
       ],
       "loadFailureMode": "warn",
       "networkQuietThresholdMs": 0,

lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-config.js

@@ -20,7 +20,6 @@ module.exports = {
       'service-worker',
       'works-offline',
       'viewport',
-      'without-javascript',
       'user-timings',
       'critical-request-chains',
       'render-blocking-resources',

lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-expectations.js

@@ -47,9 +47,6 @@ module.exports = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'user-timings': {
           scoreDisplayMode: 'notApplicable',
         },
@@ -135,9 +132,6 @@ module.exports = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'user-timings': {
           scoreDisplayMode: 'notApplicable',
         },

lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa-expectations.js

@@ -36,9 +36,6 @@ const expectations = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'load-fast-enough-for-pwa': {
         // Ignore speed test; just verify that it ran.
         },
@@ -101,9 +98,6 @@ const expectations = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'load-fast-enough-for-pwa': {
         // Ignore speed test; just verify that it ran.
         },

lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa2-expectations.js

@@ -23,9 +23,7 @@ module.exports = [
           score: 1,
         },
         'redirects-http': {
-        // Note: relies on JS redirect.
-        // see https://github.com/GoogleChrome/lighthouse/issues/2383
-          score: 0,
+          score: 1,
         },
         'service-worker': {
           score: 1,
@@ -39,9 +37,6 @@ module.exports = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'load-fast-enough-for-pwa': {
         // Ignore speed test; just verify that it ran.
         },
@@ -82,6 +77,9 @@ module.exports = [
           scoreDisplayMode: 'manual',
         },
       },
+      runWarnings: {
+        length: 1,
+      },
     },
   },
 
@@ -108,9 +106,6 @@ module.exports = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'load-fast-enough-for-pwa': {
         // Ignore speed test; just verify that it ran.
         },

lighthouse-cli/test/smokehouse/test-definitions/pwa/pwa3-expectations.js

@@ -39,9 +39,6 @@ module.exports = [
         'viewport': {
           score: 1,
         },
-        'without-javascript': {
-          score: 1,
-        },
         'load-fast-enough-for-pwa': {
         // Ignore speed test; just verify that it ran .
         },

lighthouse-core/config/default-config.js

@@ -182,7 +182,6 @@ const defaultConfig = {
     blockedUrlPatterns: ['*.css', '*.jpg', '*.jpeg', '*.png', '*.gif', '*.svg', '*.ttf', '*.woff', '*.woff2'],
     gatherers: [
       'http-redirect',
-      'html-without-javascript',
     ],
   }],
   audits: [
@@ -191,7 +190,6 @@ const defaultConfig = {
     'service-worker',
     'works-offline',
     'viewport',
-    'without-javascript',
     'metrics/first-contentful-paint',
     'metrics/largest-contentful-paint',
     'metrics/first-meaningful-paint',
@@ -622,7 +620,6 @@ const defaultConfig = {
         {id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
         {id: 'content-width', weight: 1, group: 'pwa-optimized'},
         {id: 'viewport', weight: 2, group: 'pwa-optimized'},
-        {id: 'without-javascript', weight: 1, group: 'pwa-optimized'},
         {id: 'apple-touch-icon', weight: 1, group: 'pwa-optimized'},
         {id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
         // Manual audits

lighthouse-core/gather/driver.js

@@ -682,7 +682,6 @@ class Driver {
     const waitForLoad = options.waitForLoad || false;
     /** @type {Partial<LH.Gatherer.PassContext>} */
     const passContext = options.passContext || {};
-    const disableJS = passContext.disableJavaScript || false;
 
     if (waitForNavigated && (waitForFcp || waitForLoad)) {
       throw new Error('Cannot use both waitForNavigated and another event, pick just one');
@@ -701,7 +700,6 @@ class Driver {
 
     await this.sendCommand('Page.enable');
     await this.sendCommand('Page.setLifecycleEventsEnabled', {enabled: true});
-    await this.sendCommand('Emulation.setScriptExecutionDisabled', {value: disableJS});
     // No timeout needed for Page.navigate. See https://github.com/GoogleChrome/lighthouse/pull/6413.
     const waitforPageNavigateCmd = this._innerSendCommand('Page.navigate', undefined, {url});