Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(without-javascript): remove audit #11711

Merged
merged 22 commits into from
Dec 11, 2020
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lighthouse-cli/test/cli/__snapshots__/index-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ Object {
Object {
"path": "viewport",
},
Object {
"path": "without-javascript",
},
Object {
"path": "metrics/first-contentful-paint",
},
Expand Down Expand Up @@ -1141,11 +1138,6 @@ Object {
"id": "viewport",
"weight": 2,
},
Object {
"group": "pwa-optimized",
"id": "without-javascript",
"weight": 1,
},
Object {
"group": "pwa-optimized",
"id": "apple-touch-icon",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@ module.exports = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'user-timings': {
scoreDisplayMode: 'notApplicable',
},
Expand Down Expand Up @@ -135,9 +132,6 @@ module.exports = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'user-timings': {
scoreDisplayMode: 'notApplicable',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@ const expectations = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'load-fast-enough-for-pwa': {
// Ignore speed test; just verify that it ran.
},
Expand Down Expand Up @@ -101,9 +98,6 @@ const expectations = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'load-fast-enough-for-pwa': {
// Ignore speed test; just verify that it ran.
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ module.exports = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'load-fast-enough-for-pwa': {
// Ignore speed test; just verify that it ran.
},
Expand Down Expand Up @@ -108,9 +105,6 @@ module.exports = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'load-fast-enough-for-pwa': {
// Ignore speed test; just verify that it ran.
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ module.exports = [
'viewport': {
score: 1,
},
'without-javascript': {
score: 1,
},
'load-fast-enough-for-pwa': {
// Ignore speed test; just verify that it ran .
},
Expand Down
62 changes: 0 additions & 62 deletions lighthouse-core/audits/without-javascript.js

This file was deleted.

2 changes: 0 additions & 2 deletions lighthouse-core/config/default-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,6 @@ const defaultConfig = {
'service-worker',
'works-offline',
'viewport',
'without-javascript',
'metrics/first-contentful-paint',
'metrics/largest-contentful-paint',
'metrics/first-meaningful-paint',
Expand Down Expand Up @@ -620,7 +619,6 @@ const defaultConfig = {
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
{id: 'viewport', weight: 2, group: 'pwa-optimized'},
{id: 'without-javascript', weight: 1, group: 'pwa-optimized'},
{id: 'apple-touch-icon', weight: 1, group: 'pwa-optimized'},
{id: 'maskable-icon', weight: 1, group: 'pwa-optimized'},
// Manual audits
Expand Down
12 changes: 0 additions & 12 deletions lighthouse-core/lib/i18n/locales/en-US.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions lighthouse-core/lib/i18n/locales/en-XL.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 0 additions & 61 deletions lighthouse-core/test/audits/without-javascript-test.js

This file was deleted.

26 changes: 1 addition & 25 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,6 @@
"scoreDisplayMode": "binary",
"warnings": []
},
"without-javascript": {
"id": "without-javascript",
"title": "Contains some content when JavaScript is not available",
"description": "Your app should display some content when JavaScript is disabled, even if it's just a warning to the user that JavaScript is required to use the app. [Learn more](https://web.dev/without-javascript/).",
"score": 1,
"scoreDisplayMode": "binary"
},
"first-contentful-paint": {
"id": "first-contentful-paint",
"title": "First Contentful Paint",
Expand Down Expand Up @@ -5226,11 +5219,6 @@
"weight": 2,
"group": "pwa-optimized"
},
{
"id": "without-javascript",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "apple-touch-icon",
"weight": 1,
Expand All @@ -5255,7 +5243,7 @@
}
],
"id": "pwa",
"score": 0.39
"score": 0.37
}
},
"categoryGroups": {
Expand Down Expand Up @@ -5414,12 +5402,6 @@
"duration": 100,
"entryType": "measure"
},
{
"startTime": 0,
"name": "lh:audit:without-javascript",
"duration": 100,
"entryType": "measure"
},
{
"startTime": 0,
"name": "lh:audit:first-contentful-paint",
Expand Down Expand Up @@ -6635,12 +6617,6 @@
"lighthouse-core/audits/viewport.js | description": [
"audits.viewport.description"
],
"lighthouse-core/audits/without-javascript.js | title": [
"audits[without-javascript].title"
],
"lighthouse-core/audits/without-javascript.js | description": [
"audits[without-javascript].description"
],
"lighthouse-core/lib/i18n/i18n.js | firstContentfulPaintMetric": [
"audits[first-contentful-paint].title",
"audits[timing-budget].details.items[3].label"
Expand Down