Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get chromium path from env var on Linux #119

Merged
merged 1 commit into from
Apr 4, 2016

Conversation

deepanjanroy
Copy link
Contributor

For #106

@brendankenny
Copy link
Member

I like this change. Do you want to fix it so the test server also runs it this way? Feel free to do a follow up PR instead of adding another commit to this one.

Right now the test server downloads a continuous Chrome build in test/download-chrome.sh, so you would need to

  • change chromepath in download-chrome.sh to LIGHTHOUSE_CHROMIUM_PATH and
  • drop the manual launch of Chrome on this line in .travis.yml to instead just run your launch-chrome.sh

I think we do need that extra --disable-setuid-sandbox flag for that case (a downloaded continuous build that's not Chrome and we didn't build ourselves), but not when running on Linux in general, which adds another wrinkle. For those that haven't run into this, this has more details: https://chromium.googlesource.com/chromium/src/+/master/docs/linux_suid_sandbox_development.md#Try-bots-and-waterfall

@brendankenny brendankenny added the +1 label Apr 4, 2016
@paullewis paullewis added the +2 label Apr 4, 2016
@paullewis
Copy link
Contributor

Happy to merge. Do you want to update the tests as per @brendankenny's suggestion, or roll with this as-is?

@deepanjanroy
Copy link
Contributor Author

Let me do a separate PR for the tests.

@paullewis paullewis merged commit beef04a into GoogleChrome:master Apr 4, 2016
@paullewis
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants