core(fr): convert base artifacts to gatherer artifacts #12129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
connorjclark
approved these changes
Feb 23, 2021
Co-authored-by: Connor Clark <cjamcl@google.com>
…e into fr_base_artifacts
|
@adamraine you interested in giving this a second look? :) |
adamraine
approved these changes
Feb 25, 2021
| @@ -93,7 +95,7 @@ describe('Fraggle Rock API', () => { | |||
|
|
|||
| const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr); | |||
| // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached. | |||
| expect(auditResults.length).toMatchInlineSnapshot(`65`); | |||
| expect(auditResults.length).toMatchInlineSnapshot(`67`); | |||
There was a problem hiding this comment.
Weren't there 3 gatherers added that can do snapshot mode? InstallabilityErrors, Stacks, and WebAppManifest?
There was a problem hiding this comment.
yes great catch! turns out quite a few of the artifact ids were misspelled. we have 7 more artifacts now 🎉
There was a problem hiding this comment.
I added typechecking to the new default-config that will ensure all artifact IDs used in strings are typechecked against our usages
adamraine
reviewed
Feb 25, 2021
| @@ -95,7 +95,7 @@ describe('Fraggle Rock API', () => { | |||
|
|
|||
| const {auditResults, erroredAudits, failedAudits} = getAuditsBreakdown(lhr); | |||
| // TODO(FR-COMPAT): This assertion can be removed when full compatibility is reached. | |||
| expect(auditResults.length).toMatchInlineSnapshot(`67`); | |||
| expect(auditResults.length).toMatchInlineSnapshot(`72`); | |||
There was a problem hiding this comment.
There were 4 misspellings but this jumped from 67 to 72. Is that because more than 1 audit use the same artifact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts most of the base artifacts so that they're runnable in fraggle rock as regular gatherers, but preserves the current base behavior in the legacy path as well.
environment.jsoff of driver.urlas a shared property of the FRTransitionalContextRelated Issues/PRs
ref #11313