Fix captureJSCallUsage in the face of Error polyfills. #1218
Conversation
|
@note need to write a test url to test on https://cc3test.careercruising.com/?debug=1 |
| @@ -712,19 +712,21 @@ class Driver { | |||
| * @param {function(...*): *} funcRef The function call to track. | |||
| * @param {!Set} set An empty set to populate with stack traces. Should be | |||
| * on the global object. | |||
| * @param {Error} nativeError The origal error object some libraries overwrite it. | |||
There was a problem hiding this comment.
NativeError
origal -> original
| const originalFunc = funcRef; | ||
| const originalPrepareStackTrace = Error.prepareStackTrace; | ||
| const originalPrepareStackTrace = nativeError.prepareStackTrace; |
…s overwritten) V8 has the property prepareStackTrace on errors where you can format a stacktrace. This only works on native errors not on custom ones.
wardpeet
force-pushed
the
fix-native-error
branch
from
544248d
to
01ec31b
Compare
| @@ -88,6 +88,7 @@ | |||
| <a href="./doesnotexist" target="_blank">internal link is ok</a> | |||
| </template> | |||
|
|
|||
| <script>window.Error = function(error) { this.stack = 'stacktrace'; };</script> | |||
There was a problem hiding this comment.
will you add a comment about why we're doing this and maybe referencing #1194 for future reference?
| @@ -701,7 +701,7 @@ class Driver { | |||
|
|
|||
| this.evaluateScriptOnLoad(` | |||
| ${globalVarToPopulate} = new Set(); | |||
| (${funcName} = ${funcBody}(${funcName}, ${globalVarToPopulate}))`); | |||
| (${funcName} = ${funcBody}(${funcName}, ${globalVarToPopulate}, window.__nativeError))`); | |||
There was a problem hiding this comment.
should we inject this here or just have the script assume window.__nativeError exists like evaluateAsync does? I'm not sure which is better, but it may be a bit cleaner to just use window.__nativeError inside captureJSCallUsage
| @@ -94,7 +94,8 @@ class GatherRunner { | |||
| return driver.assertNoSameOriginServiceWorkerClients(options.url) | |||
| .then(_ => driver.beginEmulation(options.flags)) | |||
| .then(_ => driver.enableRuntimeEvents()) | |||
| .then(_ => driver.evaluateScriptOnLoad('window.__nativePromise = Promise;')) | |||
| .then(_ => driver.evaluateScriptOnLoad(`window.__nativePromise = Promise; | |||
There was a problem hiding this comment.
will you pull this out into a separate function (driver.cacheNatives or something)? I'm starting to get the feeling these aren't the only two we'll end up needing to cache :)
|
…1218) V8 has the property prepareStackTrace on errors where you can format a stacktrace. This only works on native errors not on custom ones.
V8 has the property prepareStackTrace on errors where you can format a stacktrace. This only works on native errors not on custom ones.
Fixes issues like #1194