-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update typescript and axe-core to latest #12207
Conversation
@@ -118,7 +118,7 @@ | |||
"@types/ws": "^4.0.1", | |||
"@types/yargs": "^15.0.11", | |||
"@types/yargs-parser": "^15.0.0", | |||
"@typescript-eslint/parser": "^4.7.0", | |||
"@typescript-eslint/parser": "4.16.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing substantial changed in this, there's been so many releases because it shares a monorepo with the actual typescript-eslint plugin. If we don't update this, though, we get a giant
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.2.0
YOUR TYPESCRIPT VERSION: 4.2.2
warning on every run of yarn lint
:)
version "1.3.5" | ||
resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927" | ||
integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw== | ||
ini@^1.3.2, ini@^1.3.5, ini@~1.3.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive by bump of a low severity transitive dep warning that if you have enough access to exploit you might as well just run the exploit directly instead of going through the dep :) It's easy to bump and technically it's in our shipped deps, though, so, whatever.
|
I'm going to temporarily circumvent smoke-devtools to get this landed since we know this isn't the cause of #12209 |
minor bump in two deps
// @ts-expect-error
s because of improved commonjs handling (Create syntheticexports
symbol for commonjsmodule
microsoft/TypeScript#42655). Otherwise we'll now get the advantage of a few new stricter checks and improved usage of type aliases (see the TypeScript 4.2 announcement).update:sample-artifacts Accessibility
and after reverting the blob URLs (which randomize on every run) the only change was the version number, so that's great :)