Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update typescript and axe-core to latest #12207

Merged
merged 4 commits into from
Mar 11, 2021
Merged

deps: update typescript and axe-core to latest #12207

merged 4 commits into from
Mar 11, 2021

Conversation

brendankenny
Copy link
Member

minor bump in two deps

  • Only minor change from the typescript version bump is that we get to remove three // @ts-expect-errors because of improved commonjs handling (Create synthetic exports symbol for commonjs module microsoft/TypeScript#42655). Otherwise we'll now get the advantage of a few new stricter checks and improved usage of type aliases (see the TypeScript 4.2 announcement).
  • axe-core update is basically transparent. I re-ran update:sample-artifacts Accessibility and after reverting the blob URLs (which randomize on every run) the only change was the version number, so that's great :)

@brendankenny brendankenny requested a review from a team as a code owner March 5, 2021 20:17
@brendankenny brendankenny requested review from connorjclark and removed request for a team March 5, 2021 20:17
@google-cla google-cla bot added the cla: yes label Mar 5, 2021
@@ -118,7 +118,7 @@
"@types/ws": "^4.0.1",
"@types/yargs": "^15.0.11",
"@types/yargs-parser": "^15.0.0",
"@typescript-eslint/parser": "^4.7.0",
"@typescript-eslint/parser": "4.16.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing substantial changed in this, there's been so many releases because it shares a monorepo with the actual typescript-eslint plugin. If we don't update this, though, we get a giant

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <4.2.0

YOUR TYPESCRIPT VERSION: 4.2.2

warning on every run of yarn lint :)

version "1.3.5"
resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927"
integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw==
ini@^1.3.2, ini@^1.3.5, ini@~1.3.0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by bump of a low severity transitive dep warning that if you have enough access to exploit you might as well just run the exploit directly instead of going through the dep :) It's easy to bump and technically it's in our shipped deps, though, so, whatever.

@brendankenny
Copy link
Member Author

smoke-devtools dislikes me today, so while it's figuring itself out, let's bump tsc to the new patch release :)

@brendankenny
Copy link
Member Author

I'm going to temporarily circumvent smoke-devtools to get this landed since we know this isn't the cause of #12209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants