Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(devtools): dynamically fetch chromium version #12232

Merged
merged 2 commits into from
Mar 16, 2021
Merged

tests(devtools): dynamically fetch chromium version #12232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2487dc
tests(devtools): dynamically fetch chromium version
brendankenny Mar 11, 2021
515a78b
420
brendankenny Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions third-party/download-content-shell/download-content-shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@ const MAX_CONTENT_SHELLS = 10;
const PLATFORM = getPlatform();
const LH_ROOT = `${__dirname}/../..`;
const CACHE_PATH = path.resolve(LH_ROOT, '.tmp', 'chromium-web-tests', 'content-shells');
const COMMIT_POSITION_UPDATE_PERIOD = 420;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice


function main() {
fs.mkdirSync(CACHE_PATH, {recursive: true});
deleteOldContentShells();

findPreviousUploadedPosition(findMostRecentChromiumCommit())
findMostRecentChromiumCommit()
.then(findPreviousUploadedPosition)
.then(onUploadedCommitPosition)
.catch(onError);

Expand Down Expand Up @@ -64,13 +66,13 @@ function getPlatform() {
throw new Error(`Unrecognized platform detected: ${process.platform}`);
}

function findMostRecentChromiumCommit() {
// TODO: this code works only if there is a full chromium checkout present.
// const commitMessage = shell('git log --max-count=1 --grep="Cr-Commit-Position"').toString().trim();
// const commitPosition = commitMessage.match(/Cr-Commit-Position: refs\/heads\/master@\{#([0-9]+)\}/)[1];
// return commitPosition;
// TODO: make this dynamic.
return '856956';
async function findMostRecentChromiumCommit() {
const snapshotUrl = `https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/${PLATFORM}%2FLAST_CHANGE?alt=media`;
const commitPosition = Number((await utils.fetch(snapshotUrl)).toString());

// Only update the content shell roughly once a day.
// see https://github.com/GoogleChrome/lighthouse/pull/12232#discussion_r592016416
return commitPosition - commitPosition % COMMIT_POSITION_UPDATE_PERIOD;
}

function deleteOldContentShells() {
Expand Down
2 changes: 1 addition & 1 deletion third-party/download-content-shell/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function fetch(url) {

function getCallback(resolve, reject, response) {
if (response.statusCode !== 200) {
reject(new Error(`Request error: + ${response.statusCode}`));
reject(new Error(`Request error: ${response.statusCode}`));
return;
}
const body = new Stream();
Expand Down