misc: fix PhaseArtifact type to include Stacks #12280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, thanks for the assist! I think merging this into the other PR's branch would be best. |
connorjclark
approved these changes
Mar 22, 2021
|
oh, whoops, I read your merge comment the opposite way it intended, sorry :/ |
paulirish
pushed a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for the problem in #12274 (comment) We could also merge into #12274 instead of master if that's better for anyone.
The problem wasn't detected because the elements of
MetaElementshave all optional properties, so in theory could match any object (like aDetectedStack) so long as there weren't any conflicting types (e.g. if somehow there wascontent?: stringinMetaElementbutcontent: numberinDetectedStack), which there aren't.Typescript throws in one additional check for protection against accidental cases like this by ensuring that the source and target types have to have at least one property in common when one of the two types is all optional, but
MetaElementhasname?: stringandDetectedStackhasname: string, so there's no problem there.The error in #12274 occurs when adding a new required property to
MetaElement, soDetectedStackcan no longer be mistaken for an element ofMetaElements(same thing happens if you make any MetaElement property exceptnamerequired).