misc: tweak unused audits strings (remove -> reduce) #12281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
i think you can mark this as Fixes #9189
but you might also want to consider #9189 (comment) in case they strike your fancy.
Co-authored-by: Paul Irish <paulirish@users.noreply.github.com>
| /** Imperative title of a Lighthouse audit that tells the user to reduce JavaScript that is never evaluated during page load. This is displayed in a list of audit titles that Lighthouse generates. */ | ||
| title: 'Reduce unused JavaScript', | ||
| /** Description of a Lighthouse audit that tells the user *why* they should reduce JavaScript that is never needed/evaluated by the browser. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */ | ||
| description: 'Reduce unused JavaScript to reduce bytes consumed by network activity. ' + |
There was a problem hiding this comment.
FWIW both of these descriptions become slightly repetitive "Reduce...to reduce...". Maybe the descriptions can be tweaked more
paulirish
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think "remove" suggests (at least a little bit) that all unused JS/CSS should be removed. While that would be ideal, in practice that really is not possible. Slight change to "reduce" should avoid this.