tests(smoke): temporarily disable offline-warning check #12312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Mar 30, 2021
lighthouse-cli/test/smokehouse/test-definitions/offline-local/offline-expectations.js
Show resolved
Hide resolved
|
done and done
well that's not right, because I've set it so that it's asserting the most for ToT and going forwards, which means it will alert us when offline check changes are made in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work around #12311 in the smoke tests to fix CI.
Chrome 89 is stable now and
warn-not-offline-capablemay be removed from Chrome 90 in addition to Chrome 91 where it's already removed, so there didn't seem to be any point in gating this behind a_minChromiumMilestone.Leaving the actual
installable-manifestaudit unchanged for now, since if the offline check is turned back on we should get automatically notified when this smoke test fails again :)