Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer: dont check file type, try to parse json file. Fixes #1204 #1234

Merged
merged 1 commit into from
Dec 22, 2016
Merged

Viewer: dont check file type, try to parse json file. Fixes #1204 #1234

merged 1 commit into from
Dec 22, 2016

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Dec 22, 2016

R: all

brendankenny
brendankenny approved these changes Dec 22, 2016
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👜🔬🔢

@brendankenny brendankenny merged commit c5402c9 into master Dec 22, 2016
@brendankenny brendankenny deleted the 1204 branch December 22, 2016 04:15
@brendankenny brendankenny mentioned this pull request Dec 22, 2016
Closed
@XhmikosR
Copy link
Contributor

Does anybody have any idea why file.type is empty string though? I don't get why this issue happened only for me on Windows.

@ebidel
Copy link
Contributor Author

ebidel commented Dec 22, 2016

@XhmikosR I also tested on a newer windows machine and can verify .type === "" when using Chrome. I was unable to find decent information on why that could be but filed https://bugs.chromium.org/p/chromium/issues/detail?id=676671.

@XhmikosR
Copy link
Contributor

Thanks, I starred the issue to follow it. Weird indeed.

andrewrota pushed a commit to andrewrota/lighthouse that referenced this pull request Jan 13, 2017
@ebidel @andrewrota
Viewer: dont check file type, try to parse json file (GoogleChrome#1234)
3ad813b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebidel @XhmikosR @brendankenny