handle anchor tags with no href in noopener audit #1238
Conversation
| ${anchor.rel ? ` rel="${anchor.rel}"` : ''}>... | ||
| </a>` | ||
| url: '<a' + | ||
| (anchor.href !== '' ? ` href="${anchor.href}"` : '') + |
There was a problem hiding this comment.
the template string here rendered fine in the html report but took up five lines per link in the pretty print report, e.g.
<a
href="http://get.grubhub.com/?referer=seamless.com"
target="_blank"
>...
</a>
The logic also got overly complicated for dropping the href line if it was '' (since it would leave a blank line), so easier to just turn this into string concatenation.
There was a problem hiding this comment.
perhaps an array + array.join can help you make it prettier for the eyes
There was a problem hiding this comment.
it hopefully reads better with @ebidel's suggestion to make the conditionals all the same
| @@ -82,6 +82,8 @@ | |||
| <template id="noopener-links-tmpl"> | |||
| <!-- FAIL - does not use rel="noopener" to open external link --> | |||
| <a href="https://www.google.com/" target="_blank">external link</a> | |||
| <!-- FAIL - does not use rel="noopener" but no href attribute --> | |||
| <a target="_blank">external link</a> | |||
There was a problem hiding this comment.
maybe add a comment here or in the audit that when no href is given, the browser has a '' by default. Thats why you do the '' check I suppose.
| url: '<a' + | ||
| (anchor.href !== '' ? ` href="${anchor.href}"` : '') + | ||
| (anchor.target ? ` target="${anchor.target}"` : '') + | ||
| (anchor.rel ? ` rel="${anchor.rel}"` : '') + '>...' + |
There was a problem hiding this comment.
maybe we should just just drop the ...</a>. It doesn't add much.
| ${anchor.rel ? ` rel="${anchor.rel}"` : ''}>... | ||
| </a>` | ||
| url: '<a' + | ||
| (anchor.href !== '' ? ` href="${anchor.href}"` : '') + |
There was a problem hiding this comment.
(anchor.href ? \` href="${anchor.href}"\` : '') +
to be consistent with the others.
There was a problem hiding this comment.
well I was going to say what if it was like 0 or something else falsy, but that doesn't make sense :)
addresses #1233. See that issue for details on why we still include anchors with no
hrefin the audit results.We might want to leave that open as the reporting of links with no href leaves something to be desired (e.g. the first link in the seamless example ends up as
<a target="_blank" >... </a>in the URLs dropdown in the report).Not sure how to make it easier to identify the links in question without starting to write formatters for all the major frameworks, though.