-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove AMP Plugin example #12390
Conversation
Removed the "AMP Plugin" link from the plugins.md pointing to the lighthouse-plugin-amp plugin which seems to not be available anymore (points to a 404, the plugin seems to not be available anymore at the destination project).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @johannes-weber!
I don't think the project is dead, I think it just moved to a new location at https://github.com/ampproject/amp-toolbox/tree/master/packages/lighthouse-plugin-amp . Maybe update the link instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was removed afterall, sorry for the old link! See ampproject/amp-toolbox#1203
thanks @johannes-weber !
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Removed the "AMP Plugin" link from the plugins.md pointing to the lighthouse-plugin-amp plugin which seems to not be available anymore. The link points to a 404 page, the plugin seems to not be available anymore at the destination project.
Summary
Related Issues/PRs