Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove AMP Plugin example #12390

Merged
merged 2 commits into from
May 4, 2021
Merged

docs: remove AMP Plugin example #12390

merged 2 commits into from
May 4, 2021

Conversation

johannes-weber
Copy link
Contributor

Removed the "AMP Plugin" link from the plugins.md pointing to the lighthouse-plugin-amp plugin which seems to not be available anymore. The link points to a 404 page, the plugin seems to not be available anymore at the destination project.

Summary

Related Issues/PRs

Removed the "AMP Plugin" link from the plugins.md pointing to the lighthouse-plugin-amp plugin which seems to not be available anymore (points to a 404, the plugin seems to not be available anymore at the destination project).
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johannes-weber!

I don't think the project is dead, I think it just moved to a new location at https://github.com/ampproject/amp-toolbox/tree/master/packages/lighthouse-plugin-amp . Maybe update the link instead?

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed afterall, sorry for the old link! See ampproject/amp-toolbox#1203

thanks @johannes-weber !

@patrickhulce patrickhulce changed the title docs: Remove AMP Plugin example from docs/plugins.md docs: remove AMP Plugin example May 3, 2021
@patrickhulce patrickhulce marked this pull request as ready for review May 3, 2021 22:21
@patrickhulce patrickhulce requested a review from a team as a code owner May 3, 2021 22:21
@patrickhulce patrickhulce requested review from connorjclark and removed request for a team May 3, 2021 22:21
@google-cla
Copy link

google-cla bot commented May 4, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@patrickhulce
Copy link
Collaborator

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels May 4, 2021
@devtools-bot devtools-bot merged commit be0aea2 into GoogleChrome:master May 4, 2021
paulirish pushed a commit that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants