Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(treemap): fix colors #12462

Merged
merged 5 commits into from
May 11, 2021
Merged

misc(treemap): fix colors #12462

merged 5 commits into from
May 11, 2021

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented May 11, 2021

  1. Changed the stableHasher function to recycle items, so that colors never run out.
  2. I had added a fake jquery duplication to debug.json, but it turns out that there were visible duplicates but they were given white because of 1). So I removed the fake duplication.
  3. Refactored ViewMode.highlight. I figured this property should be responsible for declaring what color a specific node should be.

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 11, 2021 00:52
@connorjclark connorjclark requested review from patrickhulce and removed request for a team May 11, 2021 00:52
@google-cla google-cla bot added the cla: yes label May 11, 2021
@connorjclark connorjclark mentioned this pull request May 11, 2021
24 tasks
@connorjclark connorjclark merged commit f06807b into master May 11, 2021
@connorjclark connorjclark deleted the treemap-fix-colors branch May 11, 2021 17:57
paulirish pushed a commit that referenced this pull request May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants