deps(axe-core): upgrade to 4.2.1 #12575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lighthouse-cli/test/smokehouse/test-definitions/a11y/expectations.js
Outdated
Show resolved
Hide resolved
| @@ -57,6 +57,8 @@ async function runA11yChecks() { | |||
| 'svg-img-alt': {enabled: false}, | |||
| 'audio-caption': {enabled: false}, | |||
| 'aria-treeitem-name': {enabled: true}, | |||
| // https://github.com/dequelabs/axe-core/issues/2958 | |||
| 'nested-interactive': {enabled: false}, | |||
There was a problem hiding this comment.
'frame-focusable-content': {enabled: false} too so we aren't wasting time on it
There was a problem hiding this comment.
'frame-focusable-content': {enabled: false}too so we aren't wasting time on it
that was meant to be a question, I don't feel strongly about it :)
Not having axe tests running without any use of their output is the only real argument for disabling
brendankenny
approved these changes
May 27, 2021
There was a problem hiding this comment.
LGTM!
Sad for all the effort in #12536 but we learn a little more about accessibility in each of these updates :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of #12536 b/c we don't want to add the new audits yet, but still want to upgrade for bug fixes.