tests(treemap): add test for node coverage shading #12609
Conversation
|
|
||
| // Determine visual red shading percentage | ||
| const percentRed = await gtmElemHandle.evaluate(node => { | ||
| const redWidthPx = parseInt(window.getComputedStyle(node, ':before').width); |
There was a problem hiding this comment.
would const redWidthPx = node.clientWidth be the same?
oh, no, because pseudoelement. and no way to get a reference to that in JS.
TIL the second parameter of getComputedStyle. 0 : would make sense. 2 does too. but 1?!?
There was a problem hiding this comment.
would
const redWidthPx = node.clientWidthbe the same?
oh, no, because pseudoelement. and no way to get a reference to that in JS.
yup exactly.
TIL the second parameter of getComputedStyle. 0
:would make sense. 2 does too. but 1?!?
yeah it's weird. spec says 1 or two colons is fine. https://www.w3.org/TR/cssom-1/#dom-window-getcomputedstyle
looks like chrome works with zero, one or two colons. handy.
Co-authored-by: Connor Clark <cjamcl@google.com>
|
|
||
| // Determine visual red shading percentage | ||
| const percentRed = await gtmElemHandle.evaluate(node => { | ||
| const redWidthPx = parseInt(window.getComputedStyle(node, ':before').width); |
There was a problem hiding this comment.
would
const redWidthPx = node.clientWidthbe the same?
oh, no, because pseudoelement. and no way to get a reference to that in JS.
yup exactly.
TIL the second parameter of getComputedStyle. 0
:would make sense. 2 does too. but 1?!?
yeah it's weird. spec says 1 or two colons is fine. https://www.w3.org/TR/cssom-1/#dom-window-getcomputedstyle
looks like chrome works with zero, one or two colons. handy.
followup from #12603 (comment)
i wrote the code that was wrong, so here's my penance.
driveby change of port number... no reason it needs to conflict w/ 10200 and i'm always happy to avoid stopping my servers.