new_audit(axe): input-button-name, role-img-alt, select-name #12700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
requested changes
Jun 25, 2021
| * @url https://github.com/dequelabs/axe-core/pull/1586 | ||
| */ | ||
|
|
||
|
|
| description: 'When an input button doesn\'t have an accessible name, screen readers announce ' + | ||
| 'it as "button", making it unusable for users who rely on screen readers. ' + | ||
| '[Learn more](https://dequeuniversity.com/rules/axe/4.1/input-button-name?application=lighthouse).', | ||
| }; |
There was a problem hiding this comment.
protip: we automatically ignore max-len for lines with URLs. so you dont have to do the string concat bs (which is liable to generating spacing issues)
|
|
||
| const UIStrings = { | ||
| /** Title of an accesibility audit that evaluates if all select elements have corresponding label elements. This title is descriptive of the successful state and is shown to users when no user action is required. */ | ||
| title: 'Select elements have associated labels', |
There was a problem hiding this comment.
Suggested change
| title: 'Select elements have associated labels', | |
| title: '`<select>` elements have associated labels', |
so translators dont touch it
connorjclark
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds off #12699
Adds the 3 audits that the new test detected as missing. All 3 of them were split out of other rules we already used.. We just missed it when they were split out.
I went over all descriptions/ids carefully and i feel fairly confident its looking good.
Driveby: I added a test to confirm all audits in default config are in use by a category
update: i realize now that this PR has some overlap with #12536