Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(viewer): add disclaimer regarding devtools bug #12846

Merged
merged 3 commits into from
Aug 3, 2021
Merged

clients(viewer): add disclaimer regarding devtools bug #12846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df14656
clients(viewer): add disclaimer regarding devtools bug
connorjclark Aug 2, 2021
e0f0bdc
update
connorjclark Aug 3, 2021
2d4d55d
treemap
connorjclark Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lighthouse-treemap/app/styles/treemap.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,6 @@ header {
align-items: center;
justify-content: center;
color: #555;
font-weight: 300;
}
.treemap-placeholder-inner {
display: flex;
Expand Down
13 changes: 13 additions & 0 deletions lighthouse-viewer/app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,19 @@ <h1 class="viewer-placeholder__heading">Lighthouse Report Viewer</h1>
or <a href="https://web.dev/measure">web.dev/measure</a>.</div>
<input type="url" class="viewer-placeholder__url js-gist-url"
placeholder="Enter or paste Gist URL">

<p class="dt-disclaimer" style="display: none">
<b>DevTools users:</b> there is a <a href="https://github.com/GoogleChrome/lighthouse/issues/12841">known bug</a>
where "Open in Viewer" does not work<br>
from the DevTools Lighthouse panel. This will be fixed in<br>
Chrome 94 (around Sep 21). In the meantime, you can<br>
select "Copy JSON" from the Lighthouse report and paste the result on this page.
</p>
<script>
if (location.search === '' && document.referrer === '') {
document.querySelector('.dt-disclaimer').style.display = '';
}
</script>
</div>
</div>
</div>
Expand Down
1 change: 0 additions & 1 deletion lighthouse-viewer/app/styles/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
align-items: center;
justify-content: center;
color: #555;
font-weight: 300;
}
.viewer-placeholder-inner {
display: flex;
Expand Down