-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: npmignore all of dist/ except standalone report #12855
Conversation
.npmignore
Outdated
@@ -54,6 +53,8 @@ results.html | |||
*.lcov | |||
|
|||
# generated files needed for publish | |||
dist/* | |||
dist/report/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lets us ignore the other files in dist/report/
, which I assume we want to do
npm notice 177.4kB dist/report/bundle.js
npm notice 165.6kB dist/report/psi.js
npm notice 74.7kB dist/report/standalone.js
npm notice 12.3kB dist/report/treemap.js
npm notice 188.3kB dist/report/viewer.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering how this works, reading the docs (and making the assumption that npmignore works like gitignore) ...
From my reading of this page, nothing suggests the behavior we saw. This is the closest related thing mentioned:
[... about the !include negation pattern ...] It is not possible to re-include a file if a parent directory of that file is excluded. Git doesn’t list excluded directories for performance reasons, so any patterns on contained files have no effect, no matter where they are defined.
While I find this paragraph difficult to parse, I don't think it explains the behavior we saw, which is basically "negating a file inside a directory that has been ignored will unignore the directory"
Yeah, the docs aren't clear at all. It's more like if re-including a file the parent directory is no longer ignored.
But seriously, the explanations on that page are terrible :) |
fixes #8084
we have to explicitly ignore
dist/*
(not justdist/
) to then be able to unignoredist/report/standalone.js