report: isolate treemap type checking #12953
Merged
+50
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last functional piece of the
tsc --buildpuzzle (tsconfig cleanup to follow).The main change here is eliminating the reference to
LhlMessageswhich brings in a ton of core files.The type could be duplicated or moved to a shared
d.tsfile in the lhr types, but following the style of the equivalentUtil.i18nusage in the main report, the LhlMessages format can be flattened fromRecord<LH.Locale, {message: string}>toRecord<LH.Locale, string>in the build step that generates the strings, which actually simplifies ingestion intreemap/app/src/main.jswhere it's turning it into that format in the end anyways.