core(fr): move HostUserAgent/FormFactor back to base artifacts #12969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
patrickhulce
commented
Aug 23, 2021
| @@ -344,6 +344,7 @@ const status403 = { | |||
| // Note: most scores are null (audit error) because the page 403ed. | |||
| requestedUrl: BASE_URL + 'seo-failure-cases.html?status_code=403', | |||
| finalUrl: BASE_URL + 'seo-failure-cases.html?status_code=403', | |||
| userAgent: /Chrom(e|ium)/, // Ensure we still collect base artifacts when page fails to load. | |||
There was a problem hiding this comment.
bring back the assertion that was previously implicit that userAgent could be collected on failed runs
| @@ -38,7 +46,7 @@ function getAuditsBreakdown(lhr) { | |||
|
|
|||
| const failedAudits = applicableAudits.filter(audit => audit.score !== null && audit.score < 1); | |||
|
|
|||
| return {auditResults, erroredAudits, failedAudits, informativeAudits, notApplicableAudits}; | |||
There was a problem hiding this comment.
this wasn't used outside of this function and the new invariant means its count could be flaky, so avoiding accidental usage.
patrickhulce
force-pushed
the
fr_base_artifact_deps
branch
from
f4b2f38 to
6e8e88a
Compare
connorjclark
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves HostUserAgent/HostFormFactor artifacts back to the base. These were originally converted to individual artifacts so it was seamless for other artifacts to depend on them explicitly. We want to collect this information even when the page fails to load though, so they semantically make more sense on the base.
This PR exposes base artifacts to other artifacts as a property on context (like they already are in legacy Lighthouse), and deletes the standalone artifacts for HostUserAgent/HostFormFactor.
Related Issues/PRs
ref #11313