clients(lightrider): use iframe fetcher #13006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Sep 2, 2021
| } | ||
| return await this._fetchResourceIframe(url, options); | ||
|
|
||
| return this._fetchResourceOverProtocol(url, options); |
There was a problem hiding this comment.
swapped order because using iframe fetcher is now the exceptional case.
connorjclark
commented
Sep 2, 2021
lighthouse-core/gather/fetcher.js
Outdated
| // https://docs.google.com/document/d/1V-DxgsOFMPxUuFrdGPQpyiCqSljvgNlOqXCtqDtd0b8/edit?usp=sharing&resourcekey=0-aIaIqcHFKG-0dX4MAudBEw | ||
| async getFetcherImplBasedOnEnv() { | ||
| const {milestone} = await getBrowserVersion(this.session); | ||
| if (milestone < 92 || global.isLightrider) { |
There was a problem hiding this comment.
could have dropped the m92 thing but ehhh might as well continue on living until we kill the iframe fetcher.
adamraine
approved these changes
Sep 2, 2021
lighthouse-core/gather/fetcher.js
Outdated
| // The long timeout bug with `IO.read` was fixed in M92: | ||
| // https://bugs.chromium.org/p/chromium/issues/detail?id=1191757 | ||
| // Lightrider has a bug forcing us to use the old version for now: | ||
| // https://docs.google.com/document/d/1V-DxgsOFMPxUuFrdGPQpyiCqSljvgNlOqXCtqDtd0b8/edit?usp=sharing&resourcekey=0-aIaIqcHFKG-0dX4MAudBEw |
There was a problem hiding this comment.
nit: can you make this a normal JSDoc with /** ... */
lighthouse-core/gather/fetcher.js
Outdated
| // https://bugs.chromium.org/p/chromium/issues/detail?id=1191757 | ||
| // Lightrider has a bug forcing us to use the old version for now: | ||
| // https://docs.google.com/document/d/1V-DxgsOFMPxUuFrdGPQpyiCqSljvgNlOqXCtqDtd0b8/edit?usp=sharing&resourcekey=0-aIaIqcHFKG-0dX4MAudBEw | ||
| async getFetcherImplBasedOnEnv() { |
There was a problem hiding this comment.
nit: name this something like shouldUseLegacyFetcher and return a bool
satya-nutella
pushed a commit
to satya-nutella/lighthouse
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix to allow us to upgrade Chrome in Lightrider/PSI.
ref #12936