core(fr): add support for plugins #13028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
connorjclark
and removed request for
a team
connorjclark
reviewed
Sep 9, 2021
| try { | ||
| // Not foolproof, but `lighthouse-logger` is a dependency of lighthouse that should always be resolvable. | ||
| // `require.resolve` will only throw in atypical/bundled environments. | ||
| require.resolve('lighthouse-logger'); |
There was a problem hiding this comment.
i cri in esm evry time
( I don't have an alternative suggestion )
There was a problem hiding this comment.
except for: making build-bundle inject a globalThis.isBundled = true...
There was a problem hiding this comment.
we should be able to use createRequire/import.meta.require/require.resolve combo based on environment, though detection will be annoying :)
connorjclark
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds plugin support to Fraggle Rock along with a pubads smoketest to validate that legacy, FR, and bundled modes of Lighthouse can at least process and run plugin audits (even if it does not exercise their correctness which requires a pubads integration).
Related Issues/PRs
ref #11313