report(flow): network throttling settings #13305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Nov 2, 2021
flow-report/src/i18n/ui-strings.js
Outdated
| @@ -133,4 +133,8 @@ export const UIStrings = { | |||
| }`, | |||
| /** Label for a list of Lighthouse audits that are the most impactful. */ | |||
| highestImpact: 'Highest impact', | |||
| /** Label indicating that Lighthouse throttled the page to emulate a slow 4G network connection. */ | |||
| runtimeSlow4g: 'Slow 4G', | |||
There was a problem hiding this comment.
if you wanna put these in renderer.util that'd be great. i have some untranslated uses of those right now.
There was a problem hiding this comment.
i'm moving them.
update: #13308
paulirish
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds simple indicator for network throttling settings. Intentionally avoids mentioning the throttling method because it will be different for timespans and navigations by default.
#11313