Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(script-treemap-data): correct value for size #13716

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Mar 2, 2022

in practice I don't think this ever happens, not sure why coverage data would be missing for a script

@@ -3241,15 +3241,15 @@
},
{
"name": "http://localhost:10200/dobetterweb/empty_module.js?delay=500",
"resourceBytes": 60
"resourceBytes": 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so this is where it matters: when a scriptelement references an invalid script resource, we still try to show it in the treemap.

the upcoming #13704 will resolve this (we will only look at real scripts)

@connorjclark connorjclark changed the title core(script-treemap-data): correct value for size when missing cov core(script-treemap-data): correct value for size for missing scripts Mar 2, 2022
@connorjclark connorjclark changed the title core(script-treemap-data): correct value for size for missing scripts core(script-treemap-data): correct value for size Mar 2, 2022
@connorjclark connorjclark merged commit d684e76 into master Mar 2, 2022
@connorjclark connorjclark deleted the script-resource-size-fix branch March 2, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants