Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: clean devtools repo in CI #13758

Merged
merged 2 commits into from
Mar 18, 2022
Merged

tests: clean devtools repo in CI #13758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef1e92
wip
connorjclark Mar 18, 2022
19a9d8c
fix
connorjclark Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lighthouse-core/test/chromium-web-tests/download-devtools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,11 @@ then
git pull --ff-only -f origin main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know these two branches are the same but I don't care. do you really want to read a compound bash logic if? because I don't want to write one.

gclient sync --delete_unversioned_trees --reset
elif [ -z "${GHA_DEVTOOLS_CACHE_HIT:-}" ]; then
# For CI, just update, but only if this was a cache-miss.
# For CI, only run if this was a cache-miss.
# The only way the folder already exists _and_ there is a cache-miss is
# if actions/cache@v2 `restore-keys` has provided a partial environment for us.
# Do the same as for local, but don't clean! That would toss out all the
Copy link
Collaborator Author

@connorjclark connorjclark Mar 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoiding clean only makes sense if we were doing -x. but without that flag git will not touch the ignored folders it knows about, which is where the build artifacts are.

# (stale, but still useful) build artifacts.
git reset --hard
git clean -fd
git pull --ff-only -f origin main
gclient sync --delete_unversioned_trees --reset
fi
Expand Down