Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(full-page-screenshot): use webp instead of jpeg #13828

Merged
merged 2 commits into from
Apr 19, 2022
Merged

core(full-page-screenshot): use webp instead of jpeg #13828

merged 2 commits into from
Apr 19, 2022

Conversation

connorjclark
Copy link
Collaborator

fyi webp has been available on the protocol since m93

comparison data urls here (too big for GH markdown to render): https://gist.github.com/connorjclark/3f7f13bbc2d4fca17b8f12617105b601

25% smaller data url for cnn and quality is better.

@connorjclark connorjclark requested a review from a team as a code owner April 6, 2022 20:36
@connorjclark connorjclark requested review from adamraine and removed request for a team April 6, 2022 20:36
@connorjclark connorjclark merged commit fafe5b3 into master Apr 19, 2022
@connorjclark connorjclark deleted the webp-fps branch April 19, 2022 01:10
@paulirish
Copy link
Member

Today we learned: https://developers.google.com/speed/webp/faq#:~:text=the%20container%20specification.-,What%20is%20the%20maximum%20size%20a%20WebP%20image%20can%20be,image%20is%2016383%20x%2016383

The maximum pixel dimensions of a WebP image is 16383 x 16383.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamraine adamraine adamraine approved these changes

Assignees

@adamraine adamraine

Labels
waiting4reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @adamraine @devtools-bot