Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(assets): update logo #13919

Merged
merged 10 commits into from
Jan 23, 2023
Merged

misc(assets): update logo #13919

merged 10 commits into from
Jan 23, 2023

Conversation

paulirish
Copy link
Member

much like #9694

but updating the uses as well.

handy commands
cp assets/lighthouse-logo.svg clients/extension/images/lh_logo.svg;
cp assets/lighthouse-logo.svg treemap/app/images/lighthouse-logo.svg;
cp assets/lighthouse-logo.svg viewer/app/images/lighthouse-logo.svg;
cp assets/lighthouse-logo_512px.png viewer/app/images/lighthouse-logo_512px.png;
cp assets/lh_favicon_16px.png clients/extension/images/lh_favicon_16x16.png;
cp assets/lh_favicon_32px.png clients/extension/images/lh_favicon_32x32.png;
cp assets/lh_favicon_32px.png viewer/app/images/lh_favicon_32px.png;
cp assets/lh_favicon_76px.png viewer/app/images/lh_favicon_76px.png;

@jimoong does this look right? also want to verify you're okay with the whitespace change on the favicon? it makes it a tiny bit shorter...
though the svg seems to be bigger in its frame...

before / after:

image

more in situ (after):

image

@paulirish paulirish requested a review from a team as a code owner April 26, 2022 20:44
@paulirish paulirish requested review from connorjclark and removed request for a team April 26, 2022 20:44
@connorjclark
Copy link
Collaborator

It's very subtle, but I think the newer favicon loses some visual clarity. All the other new usages look good though.

@jimoong
Copy link

jimoong commented Apr 26, 2022

My apologies. I think I made some mistake while scaling vectors. I revised the shapes and tried not to have blurry line and removing unnecessary space on top. And for the smaller ones, I tried to increase the size of image. Original ones may look too narrow and not visible enough. Would you try with these assets again? Sorry for inconvenience.

lh_favicon_32px
lh_favicon
lh_favicon_76px

@paulirish
Copy link
Member Author

Updated before/after's

image

image

image

@connorjclark connorjclark merged commit fa89e72 into main Jan 23, 2023
@connorjclark connorjclark deleted the newlogo branch January 23, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants